[PEPr] +1 for Images::JpegMarkerReader
| From: | Michael Gauthier | Date: | Wed, 11 Jun 2008 14:14:33 +0000 |
| Subject: | [PEPr] +1 for Images::JpegMarkerReader | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50270@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has voted +1 on the proposal for
Images::JpegMarkerReader.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=559
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=559&handle=gauthierm
Comment:
Good explanation on the mailing list. Perhaps it should be added verbatim
to the package description.
Code will likely break if mb_string overloading is turned on due to use of
strlen(). It will also likely be broken for PHP6. I recommend creating a
private _strlen() method that checks for the presence of mb_string(), and
optionally uses binary casting to support PHP6.
Example:
function _strlen($string)
{
if ((ini_get('mb_string_overload') & 2) == 2) {
$len = mb_strlen($string, '8bit');
} else {
$len = strlen((binary)$string);
}
return $len;
}
--
Sent by PEPr, the automatic proposal system at http://pear.php.net