Re: Re: Request to be maintainer of Spreadsheet_Excel_Writer package
| From: | Christian Weiske | Date: | Wed, 05 Aug 2009 08:04:31 +0000 |
| Subject: | Re: Re: Request to be maintainer of Spreadsheet_Excel_Writer package | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-52573@lists.php.net to get a copy of this message | ||
Hi Franck,
> > After we reviewed, approved and merged some of your patches, you will be given
> > an svn account. From that on
> > you may commit yourself to svn.
> Thanks for karma :)
> I just added my patch to this bug :
> http://pear.php.net/bugs/bug.php?id=2405
> Is the good method ?
Yes, that's exactly right. The only problem I see in this patch is that your patch contains
more than the fix of the bug itself: You remove whitespace and the trailing newline. That should not
be part of the patch, since whitespace change can really confuse people just looking for the
actually fix (not in this case, but imagine 100+ changes in a file). Whitespace changes should be
made in separate patches/commits.
How did you test your patch?
--
Regards/Mit freundlichen Grüßen
Christian Weiske