Re: Re: Request to be maintainer of Spreadsheet_Excel_Writer package

Christian Weiske <cweiske <at> cweiske.de> writes: > > Hi Franck, > > > > After we reviewed, approved and merged some of your patches, you will be given > > > an svn account. From that on > > > you may commit yourself to svn. > > Thanks for karma :) > > I just added my patch to this bug : http://pear.php.net/bugs/bug. > > php?id=2405 > > Is the good method ? > > Yes, that's exactly right. The only problem I see in this patch is that your patch contains more than the fix > of the bug itself: You remove whitespace and the trailing newline. That should not be part of the patch, > since whitespace change can really confuse people just looking for the actually fix (not in this case, but > imagine 100+ changes in a file). Whitespace changes should be made in separate patches/commits. > > How did you test your patch? > I think it's a bug from my IDE (PHPEdit) because i just modify corrects lines. For having the diff, i make this command : svn diff Spreadsheet/Excel/Writer/Parser.php > Bug2405.0.patch But after a small search in svn help, i must do that : svn diff Spreadsheet/Excel/Writer/Parser.php > Bug2405.1.patch -x -w For testing my patch, i take back the example of the submitter (which doesn't run before) and test it.