[PEPr] Comment on Web Services::Services_BrowserMob
| From: | Michael Gauthier | Date: | Wed, 26 May 2010 16:59:05 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_BrowserMob | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53500@lists.php.net to get a copy of this message | ||
Great start, here's some feedback:
1.) Package name does not need a PEAR:: prefix in documentation.
2.) "This class acts as interface to generic Realtime Blocking Lists
(RBL)" what does that mean in relation to BrowserMob?
3.) In PEAR code, the . operator should be surrounded by spaces like other
operators.
4.) Why not pass key, secret to the constructor so they don't have to be
specified in all calls?
5.) A link to BrowserMob's available calls in the class docs would be a
good addition.
6.) use */ to close docblocks, not **/
7.) use "Signs and Calls" rather than "Sign and Call" in method
documentation.
8.) your timestamp could be generated more accurately using microtime. I
notice you append three zeros which leads me to believe this should be in
microseconds.
9.) I could see this package being called on different servers
simultaneously. In that case, you'll want to use the more_entropy flag on
uniqid so your nonces have less likelyhood of colliding.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=631