[PEPr] Comment on Web Services::Services_BrowserMob

From: Date: Thu, 27 May 2010 00:38:51 +0000
Subject: [PEPr] Comment on Web Services::Services_BrowserMob
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-53501@lists.php.net to get a copy of this message
I second all of Michael's comments. Further more: 1) It wouldn't hurt if you accepted a config/ini file either. 2) The code should probably not be PHP licensed. ;-) 3) I'm not in favor of: return json_decode(file_get_contents($request_url)); 4) Generally, I'd like to see HTTP_Request2 in there. 5) DNSRBL? ;-) 6) One thing I don't understand is why you don't implement the API at all. Like, what good is an API wrapper if I still have to learn the entire API? API wrappers should make it easier. 7) Put your code in a public repo (github, google code, ...). Helps with review. -- http://pear.php.net/pepr/pepr-proposal-show.php?id=631

« previous php.pear.dev (#53501) next »