[PEPr] +1 for Web Services::Mailman

From: Date: Sat, 14 Jan 2012 12:35:59 +0000
Subject: [PEPr] +1 for Web Services::Mailman
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-54717@lists.php.net to get a copy of this message
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for Web Services::Mailman. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=672 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=672&handle=cweiske This vote is conditional. The condition is: - Please run phpcs on your code - I'd prefer if you used simplexml+xpath instead of regex (and dom::loadhtml if necessary) - why don't you throw exceptions? currently I have to check the return value of every single method call manually instead of putting a try-catch around all of it. __construct also does swallow errors that occur in the called methods since it cannot return them. - I'd remove the default values of your class variables. Put them in the docblock ("'http://www.example.co.uk/mailman/admin';") or in your validation ("passwords-cannot-have-spaces").

« previous php.pear.dev (#54717) next »