Re: [PEPr] +1 for Web Services::Mailman

Hi Christian, Thanks for the feedback. You can see here that I've addressed your concerns: https://github.com/hm2k/Services_Mailman/commits/master However, I am still considering using simplexml+xpath over regex. I've tried working with domdocument before to parse html and it's horrible. If it's easy enough to work with and maintainable I will switch to using simplexml+xpath instead. On Sat, Jan 14, 2012 at 12:35 PM, Christian Weiske <cweiske@php.net> wrote: > Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the > proposal for Web Services::Mailman. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=672 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=672&handle=cweiske > > This vote is conditional. The condition is: > > - Please run phpcs on your code > - I'd prefer if you used simplexml+xpath instead of regex (and > dom::loadhtml if necessary) > - why don't you throw exceptions? currently I have to check the return > value of every single method call manually instead of putting a try-catch > around all of it. __construct also does swallow errors that occur in the > called methods since it cannot return them. > - I'd remove the default values of your class variables. Put them in the > docblock > ("'http://www.example.co.uk/mailman/admin';") or > in your > validation ("passwords-cannot-have-spaces"). >