Re: Re: [PEPr] +1 for Web Services::Mailman
| From: | Christian Weiske | Date: | Wed, 18 Jan 2012 19:18:15 +0000 |
| Subject: | Re: Re: [PEPr] +1 for Web Services::Mailman | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54725@lists.php.net to get a copy of this message | ||
Hello HM,
> You can see here that I've addressed your concerns:
>
> https://github.com/hm2k/Services_Mailman/commits/master
- Use your own exception class that extends Exception (or PEAR_Exception
when that is standalone available with pear 1.10) so people can catch
your exceptions.
- Use exception codes so they are distinguishable
- Use SPL exceptions when appropriate, e.g. InvalidArgumentException
- Add @throws to the docblocks
--
Regards/Mit freundlichen Grüßen
Christian Weiske
-=≡ Geeking around in the name of science since 1982 ≡=-
Attachment: [application/pgp-signature] signature.asc
Attachment: [application/pgp-signature] signature.asc