Re: testing of PEAR 1.7.0 / Space bug

Christian Weiske wrote: > Greg, > > >> Testing is easy > System/test.phpt as well as System::cat() are not safe for spaces in > the path. > > You split the files up with >> $args = preg_split('/\s+/', $args, -1, PREG_SPLIT_NO_EMPTY); > in System::cat(), which does definitely goes wrong if there is any > - even quoted - space in the path. if (!is_array($args)) { $args = preg_split('/\s+/', $args, -1, PREG_SPLIT_NO_EMPTY); } pass in an array, and no splitting is done. > In test.phpt, you pass files unquoted to System::cat(), which doubles > the problem. > Especially on Windows machines, where the temporary directory is in >> C:\Documents and Settings\My Name\Locale Settings\Temp\ > this just has to fail. > > Steps to reproduce on *nix: > $ mkdir /tmp/s\ p\ a\ c\ es > $ export TMPDIR=/tmp/s\ p\ a\ c\ es > $ pear run-tests System/test.phpt test is fixed to use an array instead of spaces. That test, btw, is probably the oldest test in the bunch - it predates my efforts to unit-test PEAR 1.4.0 Greg