Re: [Net_SMPP] Taking over unmaintained package

:) Looks like you are on your way already. On Mon, Apr 12, 2010 at 9:16 PM, Simon Spencer <silospen@silospen.com>wrote: > Thanks a lot for the list of tasks, they're very useful as I'm still trying > to read and understand all the PEAR guidelines/rules. > > Hopefully, there'll be a new release soonish! See you on IRC. > > On Mon, Apr 12, 2010 at 12:30 PM, Daniel O'Connor < > daniel.oconnor@gmail.com> wrote: > >> Karma added. >> >> Some housekeeping tasks for you when the SVN account comes through: >> 1) Upgrade to package 2.0 (pear convert && cp package2.xml package.xml) >> 2) Fix the internal directory structure (svn mkdir Net && svn mv SMPP Net >> && svn mv SMPP.php Net); and regenerate the package.xml (I suggest >> pear_packagefilemanager_cli - then it's just 'pfm' and answering a few >> questions) >> 3) Apply your patches >> 4) Some basic unit test coverage wouldn't hurt :) (PHPUnit ftw) >> 5) Prepare your new release :) >> >> We're on #pear / irc.efnet.org if you have questions, or of course the >> pear-dev mailing list. >> >> >> >> On Mon, Apr 12, 2010 at 7:46 PM, Simon Spencer <silospen@silospen.com>wrote: >> >>> Great! I applied for an SVN account with, as you guessed, the user >>> account 'silospen'. >>> >>> >>> On Mon, Apr 12, 2010 at 11:36 AM, Daniel O'Connor < >>> daniel.oconnor@gmail.com> wrote: >>> >>>> Looks good to me at a glance. >>>> >>>> Next step: get yourself an svn account and for me to set you up with the >>>> appropriate karma. >>>> http://php.net/svn.php >>>> >>>> Forwarding this email or otherwise including a link to it (ie: mail >>>> archive) doesn't hurt. >>>> >>>> I take it silospen is the user account you'll apply for? >>>> >>>> >>>> >>>> On Mon, Apr 12, 2010 at 6:54 PM, Simon Spencer <silospen@silospen.com>wrote: >>>> >>>>> On Mon, Apr 12, 2010 at 11:17 AM, Simon Spencer <silospen@silospen.com >>>>> >wrote: >>>>> >>>>> > >>>>> > >>>>> > On Mon, Apr 12, 2010 at 2:44 AM, Daniel O'Connor < >>>>> daniel.oconnor@gmail.com >>>>> > > wrote: >>>>> > >>>>> >> >>>>> >> >>>>> >> On Sun, Apr 11, 2010 at 5:23 PM, Simon Spencer < >>>>> silospen@silospen.com>wrote: >>>>> >> >>>>> >>> Hello, >>>>> >>> >>>>> >>> I'd like to express my interest in taking over the NET_SMPP >>>>> package. I'm >>>>> >>> currently implementing an ESME to send SMPP packages and I've >>>>> >>> found >>>>> a bug >>>>> >>> or >>>>> >>> two and I would like to add a few features. One of the features >>>>> >>> I'm >>>>> >>> adding >>>>> >>> is currently listed as a feature request on the site from >>>>> >>> '06. I'd >>>>> also >>>>> >>> like >>>>> >>> to add some more examples to show developers how they should use >>>>> this >>>>> >>> library as it's not really documented! >>>>> >>> >>>>> >> >>>>> >> Sounds good! Re the bugs, can you add bug reports and patches? >>>>> >> Ditto �w��v�ڥ/'�� >>>>> >> �@http://pear.php.net/bugs/bug.php?id=9492 ? >>>>> >> >>>>> >> >>>>> >> >>>>> > I've added/patched the bug I found: >>>>> > http://pear.php.net/bugs/bug.php?id=17308 >>>>> > and added a patch to: >>>>> > http://pear.php.net/bugs/bug.php?id=9492 >>>>> > >>>>> > Well, I thought I could conform to PEAR standards, but I failed to >>>>> even in >>>>> that little snippet. >>>>> http://pear.php.net/bugs/bug.php?id=17308 should >>>>> now be >>>>> correct! >>>>> >>>> >>>> >>> >> >