Re: [pear-webmaster] Comment system - ready - please test!

From: Date: Fri, 14 May 2004 23:06:40 +0000
Subject: Re: [pear-webmaster] Comment system - ready - please test!
References: 1 2 3 4  Groups: php.pear.webmaster 
Request: Send a blank email to pear-webmaster+get-2316@lists.php.net to get a copy of this message
Daniel Convissor wrote:
If you are logged in, there are buttons at every comment to do so.
There should be a note down there saying something like "to edit/approve comments you must log in."
IMHO, thats obvious. :)
Stil having problems with edit. Going to http://zuhause.bei.tobias-schlitt.de:81/comments/view.php?id=6 loging in and going to the edit button contiues to produce a blank form.
Fixed. Never change an API. ;)
On the view page, please consider right justifying the labels.
PEARWeb standard.
Okay, so now I approved the comment. Then clicked the link to visit the page it is on. Got there. Filled in the form for another comment. Hit the submit button and got an error message saying "Error: No comment posted."
Fixed.
A couple things about the display of the comments themselves. It seems putting them in <pre> would be a good idea since they may contain code samples. Also, there is too much meta information. Just show the user and date (OH! I see, that's only there if one is logged in.). Anyway, just put "Comment by <the user's email (OBFUSCATED)> on <date>" on top. This gobbles up less horizontal and vertical space.
Done, except the <pre>, since then lines are not broken automatically anymore.
Also, I think the form for new comments should be underneath the existing comments. Even better, have a link to the form at the bottom of the page.
Not sure of that. It's only harder to find then. Regards, Toby -- Tobias Schlitt GPG Key: 0xA6529579 a passion for php http://www.schlitt.info

« previous php.pear.webmaster (#2316) next »