Re: [pear-webmaster] Comment system - ready - please test!

Daniel Convissor wrote:

On the view page, please consider right justifying the labels.

PEARWeb standard.

As far as I can tell, right justification on things like this is the standard. Look at the bugs page, for instance. http://pear.php.net/bugs/bug.php?id=24

Sorry, I can't see an example for a borderbox on that page, but maybe you wanna consider http://pear.php.net/package/Net_FTP as an example for that. Anyway, when Martin commits his style changes today, I'll change the layout to fit that, which will even look nicer than that borderbox style.

Done, except the <pre>, since then lines are not broken automatically anymore.

Considering people will commonly be providing code snippets in their comments -- as happens in the PHP manual -- pre is important. Long lines can be broken using wordwrap().

Hmm... Perhaps something can be done with style sheets to make it use a fixed width font and care about white space for indenting but also do line wrapping? It's late and I'm tired, so I haven't thought this through.

Good idea! Done.

Also, I think the form for new comments should be underneath the existing comments. Even better, have a link to the form at the bottom of the page.

Not sure of that. It's only harder to find then.

What's important to find? I guess that's in the eye of the beholder. To me, it seems most people will be interested in just reading the comments. Only a few people will contribute. So, let's make it easy for the vast majority.

Done.

Thanks for tweaking the layout of the output. Some more ideas. For the sake of brevity, I suggest the format be "2004-05-15 22:30" This stuff isn't THAT time sensitive that we care about the day of the week or the time zone, let alone the seconds. With that and a slightly smaller font, we can get the name/date to fit on one line.

Done. Regards, Toby -- Tobias Schlitt GPG Key: 0xA6529579 a passion for php http://www.schlitt.info