Bug #2855 [Ana->Opn]: New bug linking system converts already linked text

From: Date: Tue, 30 Nov 2004 05:02:35 +0000
Subject: Bug #2855 [Ana->Opn]: New bug linking system converts already linked text
References: 1  Groups: php.pear.webmaster 
Request: Send a blank email to pear-webmaster+get-3489@lists.php.net to get a copy of this message
Edit report at http://pear.php.net/bugs/bug.php?id=2855&edit=1 ID: 2855 Updated by: helgi@trance.is Reported By: papercrane at reversefold dot com -Status: Analyzed +Status: Open Type: Bug Package: Bug System Operating System: Irrelevant PHP Version: Irrelevant Assigned To: dufuz New Comment: Hmm this is way out of my reach, someone with greater knowlagde of this thing has to do it. Previous Comments: ------------------------------------------------------------------------ [2004-11-29 23:47:01] helgi at trance dot is Actually iirc you were only talking about on the wiki, but well, I still want to support also "Bugs #1, #2 and #4 where fixed" and the code at the moment can't do that, and the stuff that took only "#3" would be able to handle that I guess ... I think in the bug system and in the changelogs, it's much less about people prefixing anything else then bug number with # really. But well I'm going to let it be for now I guess. ------------------------------------------------------------------------ [2004-11-29 23:37:53] papercrane at reversefold dot com I'm the one who talked him out of letting #xxxx link to a bug. It's far too easy to type something like "Look at line #1234". Also, I have a patch which would fix this, but it would take 5x the regexes as it goes a preemptive replace, then puts things back afterwards. ------------------------------------------------------------------------ [2004-11-29 23:33:19] helgi at trance dot is I'm not much of a regex person but I'll look into this, also someone removed the ability for #3454 to be turned into a link, at the moment either bug or request has to be infront of it :/ ------------------------------------------------------------------------ [2004-11-29 12:20:13] papercrane at reversefold dot com Description: ------------ See bug 2841: http://pear.php.net/bugs/bug.php?id=2841 In one of my comments I put in a link to a patch. It had the phrase bug2841 in it, which was turned into a link both within the href and in the text of the link, causing bad HTML. The bug linking should happen only when the text is not within another link. Reproduce code: --------------- Enter a link with bug2841 in a bug comment. Expected result: ---------------- Link stays as-is. Actual result: -------------- Link has a new link embedded within the href. ------------------------------------------------------------------------ -- Edit this bug report at http://pear.php.net/bugs/bug.php?id=2855&edit=1

« previous php.pear.webmaster (#3489) next »