Re[2]: [pear-webmaster] [PEAR-BUG] Bug #2855 [Opn]: New bug linking system converts already linked text
| From: | anatoly techtonik | Date: | Thu, 09 Dec 2004 18:51:49 +0000 |
| Subject: | Re[2]: [pear-webmaster] [PEAR-BUG] Bug #2855 [Opn]: New bug linking system converts already linked text | ||
| References: | 1 2 3 4 5 | Groups: | php.pear.webmaster |
| Request: | Send a blank email to pear-webmaster+get-3530@lists.php.net to get a copy of this message | ||
Hello Daniel,
From Thursday, December 9, 2004, 7:40:35 PM, you wrote:
DC> On Thu, Dec 09, 2004 at 02:36:37PM +0200, anatoly techtonik wrote:
>> - $text = preg_replace('/(?<!>)(bug|request)\s+#?([0-9]+)/i',
>> + $text = preg_replace('/(?<!>)(bug|request)\s*#?([0-9]+)'
DC> . '(?=(?>[^<]{0,100})(?!<\/a))/i',
DC> At one time the regex allowed no spaces between the word "bug" and the
DC> bug number. That lead to problems with some links being wrong, for
DC> example if a URI has "bug1234" in it. Not putting a space between the
DC> word and the number is an unusual way to file a bug report. So, in
DC> the rare case of a bug number not having the space between them, it
DC> won't be hyperlinked. Big deal.
So, I can understand, will you commit this or not? =)
It perfectly solves the problem with bug3412 in link text with every
possible rare case. I bet developers would prefer bug3423 to be converted
in link also instead of doing it manually even in "rare cases".
t
--