Re[2]: [pear-webmaster] [PEAR-BUG] Bug #2855 [Opn]: New bug linking system converts already linked text
| From: | anatoly techtonik | Date: | Fri, 10 Dec 2004 01:52:20 +0000 |
| Subject: | Re[2]: [pear-webmaster] [PEAR-BUG] Bug #2855 [Opn]: New bug linking system converts already linked text | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.pear.webmaster |
| Request: | Send a blank email to pear-webmaster+get-3532@lists.php.net to get a copy of this message | ||
Hello Daniel,
From Friday, December 10, 2004, 2:47:25 AM, you wrote:
>> DC> On Thu, Dec 09, 2004 at 02:36:37PM +0200, anatoly techtonik wrote:
>> >> - $text = preg_replace('/(?<!>)(bug|request)\s+#?([0-9]+)/i',
>> >> + $text = preg_replace('/(?<!>)(bug|request)\s*#?([0-9]+)'
>> DC> . '(?=(?>[^<]{0,100})(?!<\/a))/i',
>>
>> It perfectly solves the problem with bug3412 in link text with every
>> possible rare case. I bet developers would prefer bug3423 to be converted
>> in link also instead of doing it manually even in "rare cases".
DC> Your regex is unnecessarily complex. I won't apply it and I hope
DC> others on the web developer team won't either.
Regular expressions were invented to be used. You can always add a comment
in places where do you think it's complex. To tell the truth you don't
produce effect of a man who tried to open manual and study this regexp
a bit. I'd like to hear opinion of smb., who at least tried to understand
what this regexp do. To me it is not complex. It is very straightforward
working example and I _can_ guarantee it works and will not break. You
have my word. If you have any questions about this regexp I am open to
answer them.
DC> Anatoly, please allow this posting to be the last in this thread.
I dislike this kind of attitude and can't satisfy your request. Sorry.
:p
t
--