Re: interested in open sourcing a PHP profiler

Mikko, Using rtrim is the right fix! Thank you. This was a last minute fix, and I inadvertently used trim() instead of rtrim(). Cc'ing others in case they are trying to use xhprof_html as a non top-level directory. I'll try to pick up this fix. I'll also get the process of moving this over to pecl.php.net started. Hopefully the process of submitting patches, bug fixes, etc. will be easier to manage once it is there. regards, Kannan On Tue, Mar 17, 2009 at 7:50 AM, Mikko Koppanen <mkoppanen@php.net> wrote: > > > >> Sorry about the delay. XHProf is finally ready for release. >> > > Hello, > > I had issues if xhprof is not running on the top-level directory. Making > the links absolute on the UI seems to be fixing the issue. Here is a quick > patch: > > --- xhprof.php.orig 2009-03-17 14:31:13.000000000 +0000 > +++ xhprof.php 2009-03-17 14:31:19.000000000 +0000 > @@ -42,7 +42,7 @@ > * Our coding convention disallows relative paths in hrefs. > * Get the base URL path from the SCRIPT_NAME. > */ > -$base_path = trim(dirname($_SERVER['SCRIPT_NAME']), "/"); > +$base_path = rtrim(dirname($_SERVER['SCRIPT_NAME']), "/"); > > > /** > @@ -58,7 +58,7 @@ > function xhprof_include_js_css($ui_dir_url_path = null) { > > if (empty($ui_dir_url_path)) { > - $ui_dir_url_path = trim(dirname($_SERVER['SCRIPT_NAME']), "/"); > + $ui_dir_url_path = rtrim(dirname($_SERVER['SCRIPT_NAME']), "/"); > } > > // style sheets > > Trimming causes my $base_path to be something like debug/xhprof and that > won't work under http://servername/debug/xhprof because > the link target > becomes http://servername/debug/xhprof/debug/xhprof. > > > > -- > Mikko Koppanen >