Re: Introduction & Request for account
| From: | Johannes Schlüter | Date: | Wed, 06 Jun 2012 22:24:53 +0000 |
| Subject: | Re: Introduction & Request for account | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-9469@lists.php.net to get a copy of this message | ||
On Wed, 2012-06-06 at 12:23 +0200, Casper Langemeijer wrote:
>
> Personally, I added a patch for ssh-agent support (bug #60522) and
> would like to see that in a new version.
i had a short look at the patch, nothing obvious wrong with it. Three
small comments:
* There's mixture of whitespaces, PHP's coding standards wants
tabs, in some lines the patch uses spaces
* If zend_parse_parameters() fails we usually do a simple
'return;' which implicitly returns NULL to the user, which
complies with the behavior documented in
http://php.net/functions.internal
* The patch includes no tests, if possible it should
I think it's fine if you apply for an account and hack away and make
people happy :-)
johannes