Re: Introduction & Request for account

hi Casper, On Sun, Jun 10, 2012 at 11:10 PM, Casper Langemeijer <casper@langemeijer.eu> wrote: > Thank you for taking the time to look at my patch. > I fixed the whitespace in my local copy, when I get access I'll commit tabs > only. > > About the zend_parse_parameters() failure return: I just copied what was in > the ssh2 extension already. > I'll leave it like it is now, to keep consistency within the module, but > I'll fix all functions when I get access. yes, that can be fixed in one commit, unrelated to your patch(es) :) > > About the tests: This is hard, because ssh2 requires a ssh server to talk > to. I could write tests that need a local ssh server running, with a > specific config. If I add a --SKIPIF-- section in all tests, checking to see > if an environment variable RUN-SSH2-TEST or something is available, that > would at least help me while I'm working on the extension. Please do it, we have many extensions that require a server (imap, smtp, ftp, etc.). For the variable name, I would suggest using PHP_SSH2_TEST_SERVER instead to avoid possible local names conflicts (unlikely but more readable as well). > Another question: Would the account I applied for also get me magic powers > on bugs.php.net? Yes, but there is no magic, only some more permissions to manage bugs :) Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org