Re: Introduction & Request for account

Thank you for taking the time to look at my patch. I fixed the whitespace in my local copy, when I get access I'll commit tabs only. About the zend_parse_parameters() failure return: I just copied what was in the ssh2 extension already. I'll leave it like it is now, to keep consistency within the module, but I'll fix all functions when I get access. About the tests: This is hard, because ssh2 requires a ssh server to talk to. I could write tests that need a local ssh server running, with a specific config. If I add a --SKIPIF-- section in all tests, checking to see if an environment variable RUN-SSH2-TEST or something is available, that would at least help me while I'm working on the extension. Another question: Would the account I applied for also get me magic powers on bugs.php.net? On 06/07/2012 12:24 AM, Johannes Schlüter wrote:

On Wed, 2012-06-06 at 12:23 +0200, Casper Langemeijer wrote:

Personally, I added a patch for ssh-agent support (bug #60522) and would like to see that in a new version.

i had a short look at the patch, nothing obvious wrong with it. Three small comments:

       * There's mixture of whitespaces, PHP's coding standards wants
         tabs, in some lines the patch uses spaces
       * If zend_parse_parameters() fails we usually do a simple
         'return;' which implicitly returns NULL to the user, which
         complies with the behavior documented in
         http://php.net/functions.internal
       * The patch includes no tests, if possible it should

I think it's fine if you apply for an account and hack away and make people happy :-) johannes