Re: ext/intl

On Sun, May 10, 2009 at 9:22 PM, Hannes Magnusson <bjori@php.net> wrote: > On Sun, May 10, 2009 at 21:14, Stanislav Malyshev <stas@zend.com> wrote: >> Hi! >> >>> havent put deep thought into this .. I am sure you did though. Somehow >>> this extension continuously comes up with having people confused. So it >> >> This is a big extension - by number of functional units probably one of the >> biggest. It interfaces complex multi-functional library, which has some >> things that other extensions do not (such as more advanced error reporting). >> So understandably there could be some people that are confused, especially >> if one didn't follow it from the start (just in case, I do not imply anybody >> specifically here). >> Again, if people request adding E_WARNINGs to the error reporting, it can be >> done, I looked at the code and it should be not hard at all. > > I would greatly appreciate that, yes. > > Looking at the ext/libxml (ext/dom, ext/xmlreader, ext/xslt, > ext/xmlwriter..) error reporting for inspiration would also be good > idea > Can I add a me too? :) Aside from the error reporting, our confusion came from the fact that the docs online are all for pecl/idn and we clearly missed that bit when we tested ext/intl. But what added to the confusion was/is matching method names but different signatures and return values all over. In an effort to get people to upgrade their PHP more sooner than later, this is indeed a show stopper if you have to update your app because of the above. If there's no _good_ reason for changing the signatures and return values (e.g. omitting error codes), this shouldn't be done. Thanks for everyone's input! Till