Re: ext/intl

On Mon, May 11, 2009 at 09:11, Hannes Magnusson <bjori@php.net> wrote: > On Sun, May 10, 2009 at 23:27, Stanislav Malyshev <stas@zend.com> wrote: >> Hi! >> >> I have the patch(attached) which will do the job, but it will break most of >> the tests, since it adds error messages by default. So, one of the following >> needs to be done: >> 1. Fix all the tests to accomodate error messages >> 2. Turn off warnings by default >> 3. Turn off warnings for the tests only >> >> What do you think is preferable? > > Fixing the tests Also, remove the hardcoded functionnames from the actual errormessages. If it is wanted for intl_get_error_message() then prefix the messages with get_active_function_name() after calling php_error_docref() -Hannes