Re: ext/intl

From:	Stanislav Malyshev	Date:	Sun, 10 May 2009 19:29:38 +0000
Subject:	Re: ext/intl
References:	1 2 3 4	Groups:	php.qa
Request:	Send a blank email to php-qa+get-64939@lists.php.net to get a copy of this message

Hi!

I don't remember seeing "mysql_error_set()" which does not go via php_error_docref(). No intl errors go via php_error_docref(). They all seem to go via intl_error_set() weirdness.

That's because ICU has error reporting that is more advanced that php_error_docref() can provide. I can add php_error_docref() call to the mix if needed, but php_error_docref() definitely can not replace the existing error reporting system, not even close.

Because the ext invents its own error handling you end up with things like: bjori@jessica:/usr/src/php/5.3$ sapi/cli/php -r 'idn_to_utf8(""); var_dump(intl_get_error_message());' string(57) "idn_to_ascii: empty domain name: U_ILLEGAL_ARGUMENT_ERROR" Also note that the function name (in the message) is wrong.

Well, if there's a bug then there's a bug - you know what to do with bugs :) As for the rest - it's back to adding php_error_docref() to the mix. I'll check it out soon. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com