Re: ext/intl
| From: | Pierre Joye | Date: | Mon, 11 May 2009 07:58:21 +0000 |
| Subject: | Re: ext/intl | ||
| References: | 1 2 3 4 5 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-64953@lists.php.net to get a copy of this message | ||
hi,
On Sun, May 10, 2009 at 11:27 PM, Stanislav Malyshev <stas@zend.com> wrote:
> Hi!
>
> I have the patch(attached) which will do the job, but it will break most of
> the tests, since it adds error messages by default. So, one of the following
> needs to be done:
> 1. Fix all the tests to accomodate error messages
> 2. Turn off warnings by default
> 3. Turn off warnings for the tests only
>
> What do you think is preferable?
Sorry but adding yet another ini setting to control the error mode of
an extension is not a good thing to do. Nothing in the CS mentions
that an extension has to be noisy (use php_error_docref for
everything), or do I miss something?
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org