Re: testfest -- branch specific tests

Eric Stewart wrote:

On Tue, May 26, 2009 at 12:01 AM, Daniel Convissor < danielc@analysisandsolutions.com> wrote:

Hi Y'all: Some of the tests I put in work under 5.2 and 5.3, but the expected output is different under 6. I'd like to adjust the phpt files accordingly, but the testfest repository doesn't have branches. We could add tests named *_php6.phpt or something. Or we can make branches. Or folks moving stuff to CVS can make the needed tweaks when committing. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y

           data intensive web and database programming
               http://www.AnalysisAndSolutions.com/

4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409 -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php

Daniel, Could you provide an example of one of the tests that requires differences. There may be a way to tweak the expected output to work on all. Is it these two?

DOMDocument_schemaValidateSource_error1.phpt DOMDocument_schemaValidateSource_error2.phpt If so the PHP6 and PHP53 output could not be matched as far as I can tell, for ...error1.phpt anyway . In fact the PHP6 output looks a little odd to me, it might be worth asking if this is the intended behavior. Zoe

Eric Lee Stewart ericleestewart@gmail.com