Re: testfest -- branch specific tests

On Tue, May 26, 2009 at 11:12 AM, zoe <zoe.slattery@googlemail.com> wrote: > Daniel Convissor wrote: > >> Hi Zoe: >> >> >> >>> Is it these two? >>> >>> DOMDocument_schemaValidateSource_error1.phpt >>> DOMDocument_schemaValidateSource_error2.phpt >>> >>> >> >> Yep >> >> >> >> >>> In fact the PHP6 output looks a little odd to me, it might be worth >>> asking if this is the intended behavior. >>> >> >> I looked at the tests submitted from the NYPHP group and was surprised to see the extent of the differences between version 5.3 and 6.0. I haven't look closely yet, but this might indicate a problem or something were the warning and error messages should be brought closer together from a language stand-point. Maybe, maybe not. As I said I haven't looked closely enough yet and probably need to co-ordinate with the maintainers concerning this. > >>> >> I was thinking the same thing after I hit send. I'll poke around. >> >> That aside, what about my initial question: how should we handle tests >> that need to be different in some branches of PHP? >> >> > The plan was for PHP commiters to fix as they commited in CVS. I put the > PHP6 results on that page just to (a) show that the tests can be different, > (b) help committers to know what they needed to check/fix. Also, I thought > people who were new to writing tests might choke on being asked to write > tests for three different PHP levels :-) I agree. I think expecting people new to testing to also be able to write tests across all versions of PHP is probably a bit much, considering the learning curve just to get tests written in first place can be high. I think this is something we might want want to re-visit for next year, > perhaps provide an option to fix tests for PHP6? For the people who were in my TestFest event, I'm fixing the version compatibility problems myself and I'm emailing the submitter to let them know what I changed and why. This way they can learn for future tests but aren't bogged down in trying to figure it out themselves. > The plan is to shut this SVN repository at the end of June. I don't know if > it's worth considering an alternative plan of keeping a test repository open > (not necessarily this one)? > I don't think we'll need it passed June. Anyone who is serious about continuing to write tests is probably a good candidate for a CVS account anyway. Until then I assume they can just email new tests to the QA list as is the normal operation for non-CVSers to submit tests. > Zoe > > > Thanks, >> >> --Dan >> >> >> > > > -- > PHP Quality Assurance Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php > >