Re: testfest -- branch specific tests

Daniel Convissor wrote:

Hi Zoe:

Is it these two? DOMDocument_schemaValidateSource_error1.phpt DOMDocument_schemaValidateSource_error2.phpt

Yep

In fact the PHP6 output looks a little odd to me, it might be worth asking if this is the intended behavior.

I was thinking the same thing after I hit send. I'll poke around. That aside, what about my initial question: how should we handle tests that need to be different in some branches of PHP? The plan was for PHP commiters to fix as they commited in CVS. I put the PHP6 results on that page just to (a) show that the tests can be different, (b) help committers to know what they needed to check/fix. Also, I thought people who were new to writing tests might choke on being asked to write tests for three different PHP levels :-)

I think this is something we might want want to re-visit for next year, perhaps provide an option to fix tests for PHP6? The plan is to shut this SVN repository at the end of June. I don't know if it's worth considering an alternative plan of keeping a test repository open (not necessarily this one)? Zoe

Thanks, --Dan