Re: svn: /php/php-benchmarks/trunk/ benchweb/config.php benchweb/deploy.php benchweb/functions.php
benchweb/installers/phpbb/bench/LoremIpsum.class.php benchweb/installers/phpbb/bench/Post.php benchweb/installers/phpbb/bench/Record.php bench
| From: | Paul Biggar | Date: | Thu, 13 Aug 2009 21:48:05 +0000 |
| Subject: | Re: svn: /php/php-benchmarks/trunk/ benchweb/config.php benchweb/deploy.php benchweb/functions.php benchweb/installers/phpbb/bench/LoremIpsum.class.php benchweb/installers/phpbb/bench/Post.php benchweb/installers/phpbb/bench/Record.php bench |
||
| References: | 1 2 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65278@lists.php.net to get a copy of this message | ||
On Thu, Aug 13, 2009 at 10:33 PM, Alexander Hjalmarsson<hjalle@sgh.se> wrote:
> On Thu, Aug 13, 2009 at 10:53 PM, Hannes Magnusson <bjori@php.net> wrote:
>
>> On Thu, Aug 13, 2009 at 19:52, Alexander Hjalmarsson<hjalle@php.net>
>> wrote:
>> > hjalle Thu, 13 Aug 2009 17:52:35
>> > +0000
>> >
>> > Revision:
>> > http://svn.php.net/viewvc?view=revision&revision=287262
>> >
>> > Log:
>> > Import of the web applications benchmark. This is not complete, but it
>> works to deploy the machines (assuming you have xen working and xen-tools)
>> and benchmark a phpBB3 web server. Better documentation about how to proceed
>> will come.
>> >
>> > Changed paths:
>> [...]
>> > A php/php-benchmarks/trunk/benchweb/installers/phpbb/phpBB3/
>>
>>
>> Did you actually commit phpBB to SVN?
>> Besides the licensing issues, its not really something we want to have in
>> svn..
>
> I missed the licensing issue, sadly. I will remove it, it's just a small
> 2-line patch that differs from the original, but I can't figure out a good
> solution for this, since the web app benchmark would become pretty useless
> without applications to benchmark :/ If anyone have any suggestion how this
> could be sorted out I would be very thankful to know.. Should they be
> downloaded separately from the user-side instead perhaps?
I think the real problem is that it seem wrong to have such a large
project copied into the repository. Is there a reason we can't
download it when deploying the VMs? If its a two line patch, then
maintaining a diff wouldn't be too hard. If we could avoid having in
the repository, it would be better, but its probably not a
showstopper.
I don't think the licensing issue is the big problem here, though it
is something that needs to be addressed for the other benchmarks. We
never came to an adequate solution for the GPL code in the CLI
benchmarks.
Paul
--
Paul Biggar
paul.biggar@gmail.com