Re: Can we use PHPT instead of .php and .php.expect
| From: | Nikita Popov | Date: | Mon, 05 Jan 2015 13:03:01 +0000 |
| Subject: | Re: Can we use PHPT instead of .php and .php.expect | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.standards |
| Request: | Send a blank email to standards-+get-687@lists.php.net to get a copy of this message | ||
On Mon, Jan 5, 2015 at 2:28 AM, Sara Golemon <pollita@php.net> wrote:
> On Sun, Jan 4, 2015 at 1:11 PM, Andrea Faulds <ajf@ajf.me> wrote:
> > Well, unless including PDO will somehow change something defined by the
> language spec, I don’t see the point.
> >
> There's no point from the spec's point of view, but testing php
> regularly is a good thing. These are not completely orthogonal
> issues.
>
> > I’m proposing a separate Travis build for the spec here, by the way,
> > not adding the spec’s tests to php-src. Though I think that should also
> be done.
> >
> Because if you configure spec's travis.yml for this, then it'll only
> run when the spec changes, not on src changes. We want the spec tests
> run when anything in src changes. That means adding it to php-src's
> config.
>
> -Sara
>
I think both approaches have merit. Running the spec tests in the php-src
travis builds will prevent regressions in php-src. Running the tests from
the spec repo would prevent incorrect additions / modifications to the
tests there.
Though I agree that running the langspec tests in the php-src builds is
probably the more important part. I'll try to do that once we fixed the
tests / PHP.
Nikita