Re: Can we use PHPT instead of .php and .php.expect
| From: | Nikita Popov | Date: | Wed, 07 Jan 2015 22:44:34 +0000 |
| Subject: | Re: Can we use PHPT instead of .php and .php.expect | ||
| References: | 1 2 3 4 5 6 | Groups: | php.standards |
| Request: | Send a blank email to standards-+get-695@lists.php.net to get a copy of this message | ||
On Sun, Jan 4, 2015 at 8:49 PM, Sara Golemon <pollita@php.net> wrote:
> On Sun, Jan 4, 2015 at 8:22 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> > On Wed, Oct 8, 2014 at 2:11 AM, Stas Malyshev <smalyshev@sugarcrm.com>
> > wrote:
> > The phpt/ folder is not being kept updated. Anybody object to dropping it
> > from the repo? It's trivial to generate it using ./make_phpt
> >
> > Alternatively drop the original files and only use phpt. Probably better
> > because we have stuff like SKIPIF (for 32bit vs 64bit).
> >
> It's trivial to generate one into the other in either direction, so I
> don't care much which we declare as the source.
>
> I'm partial to .phpt, myself...
>
> -Sara
>
I've now adopted the .phpt tests as the canonical version. Should I write
some script to generate .php and .php.expect files from them, or does HHVM
already have something for that?
And as an off-topic aside: We've already fixed three minor bugs in the PHP
7 implementation thanks to the spec tests :)
Nikita