Re: Can we use PHPT instead of .php and .php.expect

Hey Nikita, > On 5 Jan 2015, at 13:03, Nikita Popov <nikita.ppv@gmail.com> wrote: > > I think both approaches have merit. Running the spec tests in the php-src travis builds will > prevent regressions in php-src. Running the tests from the spec repo would prevent incorrect > additions / modifications to the tests there. That’s basically my thinking, yes. > Though I agree that running the langspec tests in the php-src builds is probably the more > important part. I'll try to do that once we fixed the tests / PHP. It’d be great if the language spec’s tests were always part of the php-src tests, not just for Travis. Could we make php-langspec a submodule of php-src? Not sure if that would work. It would mean that you could deduplicate, too. All of my RFCs have added php-src tests and also identical HHVM-format php-langspec tests. Would be best to have one or the other, not both. Thoughts? -- Andrea Faulds http://ajf.me/