Re: svn: /web/php/branches/PROTOTYPE_2010/ css/structure.css css/theme.css index.html js/common.js js/jquery.autocomplete.pack.js
js/search-index-en.js

On Wed, Dec 30, 2009 at 11:32 PM, Hannes Magnusson < hannes.magnusson@gmail.com> wrote: > On Wed, Dec 30, 2009 at 20:30, Paul Dragoonis <dragoonis@gmail.com> wrote: > > On Wed, Dec 30, 2009 at 7:27 PM, Paul Dragoonis <dragoonis@gmail.com> > wrote: > > > >> I've spend many hours modifying the plugin core to add in some important > >> callbacks to allow us to easily customize the behaviour of the plugin at > >> different stages. > > > Wait wait wait. You modified the plugin itself? > Stewart already mentioned that plugin will contain better support for > extending it in the near future... > We cannot change plugins or any components like that. We have to be > able to upgrade them. > > Yes i modified the plugin itself, there is no appropriate callback to modify the output structure with keeping the value of the selected item the same. I will propose these changes to the plugin authors to see if they will add some of these changes in the next version, such as the "preDisplay" callback. I think we could modify the structure of the items using the "parse" callback function. However this callback is only called when XHR is performed so we can't do that either. > > >> If you type in 'a' you will see the custom found descriptions for > >> 'abs' > and > >> 'acos' items. > >> It's still to be created how we will use XHR to get the descriptions > >> dynamically from the backend as pre-populating truncated descriptions > will > >> be too heavy on the .js file size . > > The scoring is also missing.. > I didn't say scoring was included here. > > > >> My preview is hosted at: > >> http://digiflexdev.com/php/2010/ > > The 'community' tab is way below the rest of the menu items.. (using > Google Chrom 4.0.266.0 for Linux). > And the entire mysql_pconnect section is now below the right menu items... > The highlighted item color stops where the scrollbar should have been > if there are less then 10 items (try 'strpos' f.e.) > > > I have not changed any website CSS, i only changed a width value of the .ac_results class (specifically for the autocomplete) Conclusion For now i think we should go with the changes I have made and in the next version released I'm happy to incorporate my changes into the new version too. If it's not possible to easily extend the plugin then i'll add my callbacks back in. If the plugin is really good and we can extend everything then that's even better. Your thoughts are welcome. I'll work on scoring next. Cheers. Paul Dragoonis.