Re: svn: /web/php/branches/PROTOTYPE_20 10/ css/structure.css css/theme.css index.html js/common.js js/jquery.autocomplete.pack.js js/s
earch-index-en.js

On Thu, 31 Dec 2009 00:32:17 +0100, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Wed, Dec 30, 2009 at 20:30, Paul Dragoonis <dragoonis@gmail.com> wrote: >>> I've spend many hours modifying the plugin core to add in some important >>> callbacks to allow us to easily customize the behaviour of the plugin at >>> different stages. Thanks Paul, it's really nice to see the description in a working demo. It helps to gauge it's usefulness. One downside that I can see is that it limits the number of matches that we can show at one time. Maybe simpler is better here? > Wait wait wait. You modified the plugin itself? > Stewart already mentioned that plugin will contain better support for > extending it in the near future... > We cannot change plugins or any components like that. We have to be > able to upgrade them. As Hannes points out, we need to maintain forward compatibility. I think that a temporary hack to add one hook to facilitate sorting is ok at this point. The developer assured me there will be a callback for this in the future, so I think we're ok to manually add one for now. That said, I don't think it is a good idea to add any other hooks at this time because ultimately we won't want to run a custom version. Thanks! Stew