Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_constants.c

At 23:52 03/06/2003, Derick Rethans wrote:

On Tue, 3 Jun 2003, Zeev Suraski wrote: At 21:45 02/06/2003, Andi Gutmans wrote:

Can you please explain the problem? This code has worked for ages so

maybe

we introduced a bug someplace else?

It does appear as if the code was buggy, even though I don't see how it could have any negative effect. It was just allocating one extra byte for no reason. If there were any real bugs this was supposed to fix - then it does seem like a voodoo fix. We need to see some reprodicuble crash to determine where it really originates (I could be wrong in my analysis, this may actually be the source of some problem). Marcus found a problem here, and tried to fix it in the best way he could. Instead of claiming that his fixes are not right you could perhaps work together on how to reproduce this bug, or one of the countless * other ZE bugs.

If Marcus (or anybody else) doesn't have a clear understanding where a bug originates, he should not commit a fix, but send the reproducing case to the list and consult there. His fix *does* appear to be incorrect, and I see no reason to censor this assertion. I'll be happy to analyze what's going on if I had a reproducing case, which I imagine Marcus has since it fixed some crash bug he was experiencing to begin with. Zeev