Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_constants.c
| From: | (Marcus Börger) | Date: | Wed, 04 Jun 2003 06:45:25 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_constants.c | ||
| References: | 1 2 3 4 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-1322@lists.php.net to get a copy of this message | ||
At 06:31 04.06.2003, Andi Gutmans wrote:
At 12:07 AM 6/4/2003 +0200, Marcus Börger wrote:I do! That is a) the problem here and b) the inconsitency. marcusThe next thing i did which i will not revert is the following diff (notice the versions):[...] Again, this doesn't look like a thorough fix (I might be wrong). If in one case it requires you to allocate ce->name_len+1 and in another ce->name_len then someplace in the Engine isn't consistent. The correct way is to find it and fix it if possible. It doesn't make sense that ce->name_len in one case includes the terminating null and in the other it doesn't. Also in the first case don't you need to copy ce->name_len in order to copy the terminating null too?