Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_constants.c

At 21:45 02/06/2003, Andi Gutmans wrote:

Can you please explain the problem? This code has worked for ages so maybe we introduced a bug someplace else?

It does appear as if the code was buggy, even though I don't see how it could have any negative effect. It was just allocating one extra byte for no reason. If there were any real bugs this was supposed to fix - then it does seem like a voodoo fix. We need to see some reprodicuble crash to determine where it really originates (I could be wrong in my analysis, this may actually be the source of some problem). Marcus - our "no voodoo fixes" is a real, strict rule. It's fine that you think it's a bad rule, but it's still there. If you have a fairly good understanding that you're actually fixing a symptom, and not the problem itself - do not commit a patch. Consult the engine2 list instead. We prefer to go on crashing and be able to find the real bug than covering it, and having to go nuts when we actually try to find it in the future. Zeev