Re: cvs: CVSROOT / loginfo.pl

On Fri, 7 Sep 2001, Sterling Hughes wrote: > sterling Fri Sep 7 19:37:42 2001 EDT > > Modified files: > /CVSROOT loginfo.pl > Log: > Use Net::SMTP and enable sending commit messages to multiple addresses > Eek, I commited more than i meant to (for this commit). But the other stuff is things that should be in there anyway 1) remove the & before the beginning of the function calls, this is a Perl 4'ism and is bad practice in Perl 5 code. 2) Standardize the call's to open() and add error reporting, $! is equivalent to strerror(errno) in C. Note the \n after $!, this is important, makes it so that die looks a bit cleaner :) 3) chop() is not the same in PHP as in Perl, in Perl you'll be wanting chomp() which removes all whitespace instead of just the last character. 4) statement if statement, not statement if (statement) is the generally agree'd upon idiom (as far as I can see). 5) my (@ar) = value; is better expressed as my @ar = value; as the array context is already there... And finally, we should really be using MIME::Lite to construct the message, does anyone have any objections to me switching to use this? -Sterling