Re: cvs: CVSROOT / loginfo.pl

> 3) chop() is not the same in PHP as in Perl, in Perl you'll be > wanting chomp() which removes all whitespace instead of just the > last character. Sterling, this script has not been written by some novice PHP programmers with no experience in Perl. Of course, the code was designed to use only one whitespace character, and thus chop is perfectly fine. > 4) statement if statement, not statement if (statement) is the > generally agree'd upon idiom (as far as I can see). You might want to review what you commit first. -exit 0 if(fork() ne 0); +exit 0 if fork() ne 0; > And finally, we should really be using MIME::Lite to construct the > message, does anyone have any objections to me switching to use > this? As long as it does not break.. [reading a couple more emails] The latest CVS commit messages I saw are broken. - Sascha Experience IRCG http://schumann.cx/ http://schumann.cx/ircg