Re: include_path question

On Sun, 27 Aug 2000, Andi Gutmans wrote: > At 09:39 PM 8/27/00 +0200, Sascha Schumann wrote: > > > > What is wrong with your patch? It should work with every web > > > > server which passes an absolute path in primary_file. > > > > > > I thought it doesn't work with CGI but I checked and CGI seems to be a > > good > > > boy and set path_translated to full path too :) > > > > The last change should take care of all SAPI modules which > > pass a relative path to php_execute_script(). > > I don't like your patch. It shouldn't be there because it is broken. SAPI > modules should make sure that path_translated is full path. It is supposed > to be this way and I doubt the modules do anything differently. If we find > such a SAPI module the full path needs to be calculated there and not in > main.c. That is based on the sole assumption that php_execute_script() is a well-defined interface. In fact, it is not. It is a convenience function, loosely grouping functionality which is commonly used by SAPI modules. The recently added check is such a convenient feature to avoid duplicating the code in multiple places. - Sascha