Re: include_path question

From: Date: Sun, 27 Aug 2000 19:43:04 +0000
Subject: Re: include_path question
References: 1  Groups: php.dev 
Request: Send a blank email to php-dev+get-30841@lists.php.net to get a copy of this message
At 09:39 PM 8/27/00 +0200, Sascha Schumann wrote:
    What is wrong with your patch? It should work with every web
    server which passes an absolute path in primary_file.
I thought it doesn't work with CGI but I checked and CGI seems to be a good boy and set path_translated to full path too :)
    The last change should take care of all SAPI modules which
    pass a relative path to php_execute_script().
I don't like your patch. It shouldn't be there because it is broken. SAPI modules should make sure that path_translated is full path. It is supposed to be this way and I doubt the modules do anything differently. If we find such a SAPI module the full path needs to be calculated there and not in main.c. Please let's try and keep the core code as clean as possible. Please revert this patch. Andi --- Andi Gutmans <andi@zend.com> http://www.zend.com/

« previous php.dev (#30841) next »