Re: include_path question

At 12:25 AM 8/28/00 +0300, Zeev Suraski wrote:

At 22:55 27/08/2000, Andi Gutmans wrote:

At 10:43 PM 8/27/00 +0300, Andi Gutmans wrote:

At 09:39 PM 8/27/00 +0200, Sascha Schumann wrote:

    What is wrong with your patch? It should work with every web
    server which passes an absolute path in primary_file.

I thought it doesn't work with CGI but I checked and CGI seems to be

a good

boy and set path_translated to full path too :)

    The last change should take care of all SAPI modules which
    pass a relative path to php_execute_script().

I don't like your patch. It shouldn't be there because it is broken. SAPI modules should make sure that path_translated is full path. It is supposed to be this way and I doubt the modules do anything differently. If we find such a SAPI module the full path needs to be calculated there and not in main.c. Please let's try and keep the core code as clean as possible. Please revert this patch.

I reverted it myself. It's really not correct (please read the commit msg). I'd appreciate it if you left the code the way it is. By the way, in my commit msg I also mention old_cwd(). In ISAPI we have 10KB of stack space so having it take up 4KB is a big problem because it's in the call-stack to execute_script() and not a small temporary function. We should probably emalloc() it.

We don't have just 10KB of stack space under ISAPI, we have 256KB. It's very little as well, though.

Since when? It used to be 10KB I'm pretty sure of that. Andi --- Andi Gutmans <andi@zend.com> http://www.zend.com/