Re: Question about merged PR #937
| From: | Christoph M. Becker | Date: | Thu, 19 Sep 2019 16:58:04 +0000 |
| Subject: | Re: Question about merged PR #937 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-107233@lists.php.net to get a copy of this message | ||
On 19.09.2019 at 17:01, guilhermeblanco@gmail.com wrote:
> One of my old PRs to PHP that was claimed to be merged disappeared
> from master. However, the upgrade note is still there in master and
> 7.4beta1.
>
> Here is the PR: https://github.com/php/php-src/pull/937
> Here is the commit referencing it:
>
> https://github.com/php/php-src/commit/0adfa03397edcde8cba3bae2032b1f2ef26ea760
>
> Please let me know if there's anything I can do to help.
From what I can tell, everything is there. PR #911 has been merged as
<http://git.php.net/?p=php-src.git;a=commit;h=094d409b3d34c51f49e0121e5ccfe8b2a717aaf6>,
and parts of that PR already with PR #928 as
<http://git.php.net/?p=php-src.git;a=commit;h=f48c2327403ce76a870e74f31a069a64dfb711a2>.
--
Christoph M. Becker