Re: Question about merged PR #937

Thanks for the clarification Christoph! Somehow I couldn't see it when looking for the commit hash. Sorry for the disturbance in the list here. PS: I find it funny that even though I'm the original author of the code, I don't show as a contributor in any statistics. It'd be a shame to not be considered as a valid voter for "lack of recent contribution" to the language. Cheers, On Thu, Sep 19, 2019 at 12:58 PM Christoph M. Becker <cmbecker69@gmx.de> wrote: > > On 19.09.2019 at 17:01, guilhermeblanco@gmail.com wrote: > > One of my old PRs to PHP that was claimed to be merged disappeared > > from master. However, the upgrade note is still there in master and > > 7.4beta1. > > > > Here is the PR: https://github.com/php/php-src/pull/937 > > Here is the commit referencing it: > > > > https://github.com/php/php-src/commit/0adfa03397edcde8cba3bae2032b1f2ef26ea760 > > > > > > Please let me know if there's anything I can do to help. > > From what I can tell, everything is there. PR #911 has been merged as > > <http://git.php.net/?p=php-src.git;a=commit;h=094d409b3d34c51f49e0121e5ccfe8b2a717aaf6>, > and parts of that PR already with PR #928 as > > <http://git.php.net/?p=php-src.git;a=commit;h=f48c2327403ce76a870e74f31a069a64dfb711a2>. > > -- > Christoph M. Becker -- Guilherme Blanco SVP Technology at Statflo Inc. Mobile: +1 647 232 5599