Re: Re: Question about merged PR #937
| From: | Christoph M. Becker | Date: | Fri, 27 Sep 2019 09:40:17 +0000 |
| Subject: | Re: Re: Question about merged PR #937 | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-107340@lists.php.net to get a copy of this message | ||
On 27.09.2019 at 11:25, Alexandru Pătrănescu wrote:
> The method you described looks great.
> Squashing with rebase interactive works fine, with choosing what commits to
> keep and what commits to squash into the kept ones.
> This can be done by merger or author.
>
> Merging a pull request with squashing in github will set the author's
> commit to the person who merge it.
> The same things happens with *git merge --squash <branch>*
>
> If you agree, what would be the best way to propagate this information so
> that everyone use this method, when squashing is needed?
I'm not sure if any commit actually removed the author information.
<https://github.com/php/php-src/commit/0adfa03397edcde8cba3bae2032b1f2ef26ea760>
certainly didn't, since this commit was not the actual merge, but rather
NEWS and UPGRADING information related to that PR.
So, where is the problem? :)
Regards,
Christoph