Re: Re: Question about merged PR #937
| From: | Alexandru Pătrănescu | Date: | Fri, 20 Sep 2019 10:35:12 +0000 |
| Subject: | Re: Re: Question about merged PR #937 | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-107263@lists.php.net to get a copy of this message | ||
Hi Christoph,
Was this squash done during merging of a github pull request?
On Fri, Sep 20, 2019 at 1:06 PM Christoph M. Becker <cmbecker69@gmx.de>
wrote:
> On 20.09.2019 at 11:22, Alexandru Pătrănescu wrote:
>
> > I was quick to write an answer and forgot to search for a more detailed
> > explanation online, being busy with some other work tasks.
> > Github explains it here:
> >
> > https://help.github.com/en/articles/about-merge-methods-on-github
> >
> > Before enabling squashing commits, consider these disadvantages:
> >>
> >> - You lose information about when specific changes were originally
> >> made and who authored the squashed commits.
>
> <
>
> http://git.php.net/?p=php-src.git;a=commit;h=8326ef5519acb4dfcdcd3f059ee599d9e0faf174
> >
> has just been squashed by me, and still has the proper author information..
>
> --
> Christoph M. Becker
>