Re: Question about merged PR #937
| From: | Christoph M. Becker | Date: | Fri, 20 Sep 2019 08:59:20 +0000 |
| Subject: | Re: Question about merged PR #937 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-107256@lists.php.net to get a copy of this message | ||
On 19.09.2019 at 19:20, guilhermeblanco@gmail.com wrote:
> Thanks for the clarification Christoph!
> Somehow I couldn't see it when looking for the commit hash. Sorry for
> the disturbance in the list here.
>
> PS: I find it funny that even though I'm the original author of the
> code, I don't show as a contributor in any statistics.
> It'd be a shame to not be considered as a valid voter for "lack of
> recent contribution" to the language.
>git log --author=Blanco --pretty=oneline
4498d34aeaadcbc2ab64b9c0f40f336bf363b2d6 Check interface/trait extension
for internal classes
8c81d80e10e0f189307fc8ff4a8fb34bd0cb1fcb Made ZEND_ACC_TRAIT a saner value
d51fb69c0125a144cacb8c59df89fea3f8ae7f4b Removed parsing support traits
to have extends and implements.
f48c2327403ce76a870e74f31a069a64dfb711a2 Decoupled class declaration
statement into more granular pieces.
094d409b3d34c51f49e0121e5ccfe8b2a717aaf6 Removed ZEND_ACC_FINAL_CLASS
which is unnecessary. This also fixed some currently defined classes as
final which were just not being considered as such before.
Looks good. :)
--
Christoph M. Becker