Re: Re: [php-icu] Re: [PHP-DEV] Re: [php-icu] Graphemes and unicode vs intl extension
| From: | Stanislav Malyshev | Date: | Wed, 26 Mar 2008 21:01:59 +0000 |
| Subject: | Re: Re: [php-icu] Re: [PHP-DEV] Re: [php-icu] Graphemes and unicode vs intl extension | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36577@lists.php.net to get a copy of this message | ||
Hi!
I meant to duplicate the code from ext/date (where it belongs) in pecl/intl. Please notice the "pecl/intl" not php-src/ext. The goal is to provide the DateFormatter feature to php 5.2 users.Great, right now 5.2 users can use intl extension from pecl, including DateFormatter.
As Derick said, it should be in ext/date. I quickly reviewed the dateformat/* code and did not catch any stopping point to actually move the code in ext/date. I agree that it will add some tiny extraYou'll also need to copy error handling and charset conversion, at least.
work but it is really worth the effort. Having the date code in one place will benefit the users, from a quality and usability point of view.Actually, the users couldn't care less in which directory the source code was located. They care about the API provided - so do you propose to provide different API? If so, which one? As for quality, I don't see what extra quality would copying this code provide.
That could work as well as long as it is: - completely transparent to the users (no worry here) - team work and (very) good communication between ext/date maintainers and intl maintainers (I worry more here ;), that means ext/date maintainers should have a word/voice in intl :)As I already said, anybody who wants to contribute is welcome. Actually, only discussion on date (or any non-bug-related matters for that matter :) is held for now right here. If you want to move it, say, to php-i18n, I'm OK with that too. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com