Re: cvs: php-src /ext/date config.w32 /ext/date/lib parse_iso_intervals.re

On Sun, Aug 3, 2008 at 5:51 PM, Derick Rethans <derick@php.net> wrote: > On Sat, 2 Aug 2008, Pierre-Alain Joye wrote: > >> pajoye Sat Aug 2 16:49:56 2008 UTC >> >> Modified files: >> /php-src/ext/date config.w32 >> /php-src/ext/date/lib parse_iso_intervals.re >> Log: >> - improve previous fix for scan, disable optimizer only for scan() using #pragma optimize > > This is non-sense. The scan function in parse_iso_intervals.c is only > 750 lines long, while the scan function in parse_date.c is 21000 lines > long. And there is no problem with the latter function. If you want to > work around bugs in compilers, then stick that in the config.w32 file - > I don't want silly windows only defines in the code. Asking to support 10 years old compiler and SDK and at the same time reject fixes for them do not make sense to me. However it is barely relevant, your code is in core, part of the standard feature and is always enabled, it must work for windows as well (and that means VC6 and VC9 support). Also please note that we can surely enable the optimizer for VC8 and VC9 as soon as I'm sure that it works fine (it does for the 1st tests). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org