Re: Re: cvs: php-src /ext/date config.w32 /ext/date/lib parse_iso_intervals.re

hi Derick, On Wed, Aug 6, 2008 at 8:59 AM, Derick Rethans <derick@php.net> wrote: > On Wed, 6 Aug 2008, Pierre Joye wrote: > >> On Tue, Aug 5, 2008 at 11:59 PM, Johannes Schlüter <johannes@php.net> wrote: >> >> > Simple question yes/no is enough for me: >> > Can it be done, using the build system, in a per-file way or only per >> > extension? (If yes per-file, I'd prefer that way, else: keep the #ifdef) >> >> Per extension (as done in the first fix) only and that's a bad idea to >> disable it, it is already slow enough. > > That's irrelevant as MS VC 6 is slow anyway. Please remove this silly > #ifdef until you find out what is the *real* cause here. I don't like > symptom plugging. Until you find out the real reason, fix this in the > build system instead of with hacks in files. (And if you're not willing > to change it back, I will). The RMs clearly stated that we have to keep the #ifdef. I don't think ext/date is any different from any other extensions in core, especially as it is part of the standard feature. That being said, it would be nice if you have a bit more consideration of the work of the other people, especially when they work in their free time on your code, to improve, fix or test it. A despote-like attitude is nice and shiny in PECL or anywhere else but not in php-src/*. Thanks for your understanding. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org