Re: Re: cvs: php-src /ext/date config.w32 /ext/date/lib parse_iso_intervals.re
| From: | Derick Rethans | Date: | Wed, 06 Aug 2008 06:59:05 +0000 |
| Subject: | Re: Re: cvs: php-src /ext/date config.w32 /ext/date/lib parse_iso_intervals.re | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39687@lists.php.net to get a copy of this message | ||
On Wed, 6 Aug 2008, Pierre Joye wrote:
> On Tue, Aug 5, 2008 at 11:59 PM, Johannes Schlüter <johannes@php.net> wrote:
>
> > Simple question yes/no is enough for me:
> > Can it be done, using the build system, in a per-file way or only per
> > extension? (If yes per-file, I'd prefer that way, else: keep the #ifdef)
>
> Per extension (as done in the first fix) only and that's a bad idea to
> disable it, it is already slow enough.
That's irrelevant as MS VC 6 is slow anyway. Please remove this silly
#ifdef until you find out what is the *real* cause here. I don't like
symptom plugging. Until you find out the real reason, fix this in the
build system instead of with hacks in files. (And if you're not willing
to change it back, I will).
regards,
Derick
--
HEAD before 5_3!: http://tinyurl.com/6d2esb
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org