Re: Re: cvs: php-src /ext/date config.w32 /ext/date/lib parse_iso_intervals.re

hi, On Mon, Aug 4, 2008 at 12:50 PM, Johannes Schlüter <johannes@php.net> wrote: > Correct PHP is supposed to work on "all" platforms therefore the code > has to work on Windows, too. And now it does. > Now there are two questions Derick ask, which I see as valid questions: > a) Why does it break with that function while at least another bigger > one exists. http://msdn.microsoft.com/en-us/library/1dy6t14d(VS.80).aspx There is three possible causes. > b) In general the build system is not only for putting the stuff in the > compiler but also detecting compiler problems and working around them. Yes, and that's what we do. Two > Is it possible to do this work around in the build file? Please read my other replies, it is possible but not as clean as the last fix. > So as a summary: The nicest code is worthless if we can't compile it on > our platforms, but build fixes should be places where they hurt the > less. Do you suggest that disabling the optimization for the whole date extension will heart less than 4 lines in the src code? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org